Repository navigation
test: generate every demo workflow for every build type - #674
Open
yadavchiragg wants to merge 1 commit into
Open
yadavchiragg wants to merge 1 commit into
yadavchiragg wants to merge 1 commit into
Conversation
|
🎉 Welcome aboard, @yadavchiragg! Thank you for your first pull request in concore. Please ensure that you are contributing to the dev branch. Your contribution means a lot to us. We'll review it shortly. Please ensure you have reviewed our: If you have any questions, feel free to ask. Happy coding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: nothing checks that the demo workflows still generate a study after a change to
mkconcore.py. A workflow for a language the generator doesn't support (for exampledemo/sampleJ.graphml, which uses Julia nodes) fails withExtension .jl is unsupported, and nobody sees it until a user builds that workflow.Change: new
tests/test_demo_workflows_generate.pyrunsmkconcore.pyon everydemo/*.graphmlfor posix, windows and docker. It checks that generation succeeds, that the expected scripts exist and are non-empty, and thatsrc/was created. The whole file runs in about 7 seconds.sampleJ.graphmlon posix and windows is markedxfailwith a reason, because Julia nodes are not supported in local builds yet. The list is inKNOWN_UNSUPPORTEDat the top of the file, so the entry can be deleted when that support lands.Testing: all other cases pass. With the
KNOWN_UNSUPPORTEDentries removed, exactly the two Julia cases fail, which shows the test catches a real unsupported-language failure.ruff format --checkandruff checkare clean.